Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: add jsDocs to exported methods #137

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Chore: add jsDocs to exported methods #137

merged 1 commit into from
Oct 3, 2024

Conversation

Cussone
Copy link
Member

@Cussone Cussone commented Oct 3, 2024

Issue / feature description

Exported methods lack JS docs, it is really helpful for some user so I'm adding them to the functions used externaly

Changes

Adding JS Docs to connect, disconnect, getSelectedConnectorWallet, and useStarknetkitConnectModal

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@Cussone Cussone requested a review from bluecco October 3, 2024 14:36
@Cussone Cussone merged commit 3a15950 into develop Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluecco bluecco bluecco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cussone @bluecco